Fix: do not use the value field as a next pointer - #1419
Merged
bratpiorka merged 1 commit intoJul 4, 2025
Merged
Conversation
Do not use the value field as a next pointer, because it sometimes can lead to race conditions and reusing already used leaves. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Contributor
Author
|
@lplewa @bratpiorka please review |
lplewa
approved these changes
Jul 4, 2025
bratpiorka
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not use the value field as a next pointer,
because it sometimes can lead to race conditions
and reusing already used leaves like here:
https://github.com/ldorau/unified-memory-framework/actions/runs/16074523240/job/45366469415
Description
Checklist